-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ddp_spawn dataloader checks on windows #6930
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6930 +/- ##
=======================================
- Coverage 92% 87% -4%
=======================================
Files 194 194
Lines 12347 12345 -2
=======================================
- Hits 11322 10774 -548
- Misses 1025 1571 +546 |
@carmocca does this affect Horovod somehow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
No, the Horovod failure is unrelated. Probably another flaky test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems you fixed Win but broke Linux
What does this PR do?
Fixes current failing windows tests
The fix is removing the
on_windows
skip. I don't know why we were skipping it.Before submitting
PR review