-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate typing #310
Annotate typing #310
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
==========================================
- Coverage 89.72% 88.29% -1.43%
==========================================
Files 16 17 +1
Lines 4037 4159 +122
Branches 942 978 +36
==========================================
+ Hits 3622 3672 +50
- Misses 282 316 +34
- Partials 133 171 +38 ☔ View full report in Codecov by Sentry. |
final ironing out for type hints, run `mypy linopy` successfully
@lkstrp could I kindly ask you to take over fixing the pre-commit bot. It looks like the pre-commit CI is sort of stuck with another set of (cached ?) arguments. Locally it works fine. What I want in the end is to run mypy checks on |
@lkstrp awesome thanks |
Add type annotations & add MyPy to pre-commit hooks. This is quite a large change, but the functional change is kept to a minimum.
closes #303
closes #185