-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix exclusion for non overlapping geometries #289
Conversation
add convenience functions to ExclusionContainer class
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 72.74% 72.80% +0.05%
==========================================
Files 19 19
Lines 1596 1625 +29
Branches 270 277 +7
==========================================
+ Hits 1161 1183 +22
- Misses 363 366 +3
- Partials 72 76 +4
☔ View full report in Codecov by Sentry. |
d07d1e1
to
72c0831
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new functions!
Nice. Did you intentionally remove |
Not really, was there a renaming? It is still in the list of selected countries... |
Yes, the country was officially renamed in 2019. Probably the name change took some time to propagate to the datasets. |
and add convenience functions to ExclusionContainer class
Change proposed in this Pull Request
In recent eligibility calculations in pypsa-eur we saw bugs coming up, when the raster and the geometries are not overlapping. This changes fix this issue.
Additionally this change introduces two new functions to the
ExclusionContainer
class that ease the inspection of excluded areas in a geometry.The example notebook for show-casing the land-use calculation was update to show the new functions.
Type of change
Checklist
pytest
inside the repository and no unexpected problems came up.doc/
.environment.yaml
file.doc/release_notes.rst
.pre-commit run --all
to lint/format/check my contribution