Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for zlib compression in .nc file cutout exports #281

Merged
merged 6 commits into from
Mar 18, 2023
Merged

Conversation

fneum
Copy link
Member

@fneum fneum commented Mar 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.02 ⚠️

Comparison is base (2f55e26) 72.84% compared to head (8ace7e7) 72.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   72.84%   72.83%   -0.02%     
==========================================
  Files          19       19              
  Lines        1587     1590       +3     
  Branches      225      227       +2     
==========================================
+ Hits         1156     1158       +2     
  Misses        362      362              
- Partials       69       70       +1     
Impacted Files Coverage Δ
atlite/data.py 86.04% <75.00%> (-0.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@euronion euronion closed this Mar 17, 2023
@euronion
Copy link
Collaborator

Rejected

@euronion euronion reopened this Mar 17, 2023
@euronion
Copy link
Collaborator

For reasons which are obvious.

@euronion
Copy link
Collaborator

euronion commented Mar 17, 2023

I've directly commited a simpler version into your branch:

  • without the additional function (not needed) and the ability to specify compression levels for an individual feature rather than re-applying the compression to all the data (potentially requiring recompression of existing features)
  • Also: enabled by default (because it doesn't hurt)
  • Removed additional function
  • to_file(..) continues to work this way and no further code changes necessary :)

@fneum fneum merged commit f9bd7fd into master Mar 18, 2023
@fneum
Copy link
Member Author

fneum commented Mar 18, 2023

I approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants