-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NREL turbine data to atlite #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thesethtruth ,
thanks for the PR! You are right: We have been putting off introducing new turbines for a long time. There are a two things which need to be adressed. See the comments in one of the files (the comments apply to all files).
Let me know if you have any questions.
atlite/resources/windturbine/2016CACost_NREL_Reference_10MW_205_offshore.yaml
Outdated
Show resolved
Hide resolved
atlite/resources/windturbine/2016CACost_NREL_Reference_10MW_205_offshore.yaml
Outdated
Show resolved
Hide resolved
Comments from @euronion processed. If in the future you'd want to parse the data yourself; I've automated most in https://github.com/thesethtruth/NREL-to-atlite-turbines. Cheers! |
Nice, LGTM, thanks @thesethtruth ! Pinging @fneum since you've discussed this earlier elsewhere: Is it GTM? |
GTM! Thanks! |
Ah; nearly missed it: Can add a oneliner to the RELEASE_NOTES mentioning new turbines ? @thesethtruth |
Done! See below:
|
Great, thanks! |
Thanks for that merge, quite helpful! As a further idea you could consider adding your existing parsing code directly to atlite as an extension to cutout.wind(turbine="nrel:2016CACost_NREL_Reference_8MW_180") to transparently fetch the turbine defined at https://nrel.github.io/turbine-models/2016CACost_NREL_Reference_8MW_180.html That would work by adding a new hook in Lines 52 to 53 in 2ab6c9e
And putting your code into a new function like Lines 238 to 371 in 2ab6c9e
Maybe that is good first issue. But, many thanks either way! |
@coroa Thanks for your comment. I had the email notification parked for a long time now (hence the late response) hoping I would find the time to implement your suggestion. Unfortunately, I won't be able to since I'm very tight for time at the moment. If I have time at a later stage and this is still relevant I will implement it! |
Description
Adds more turbine .yaml to the database.
Motivation and Context
Some turbines in the current database are a bit outdated. Moreover, if used in ESOM, users might want to use power curves for future / expected turbine types (with a higher rated power and different power curve). This is done based on the NREL turbine data set, which I've parsed to the atlite format using some basic python and Jinja2 templating (see: turbine parsing repo).
In our current project we use PyPSA-eur and felt like this feature was limiting. This was discussed with @fneum.
How Has This Been Tested?
Tested in an PyPSA run and through atlite on ERA5 dataset
Type of change
Extension of existing data
Feel free to propose updates / changes. Let me know what you need to use this data.