-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/exclusioncalculator filehandling #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@euronion thanks for taking care of this.
for more information, see https://pre-commit.ci
@FabianHofmann Can you have another look? I added a temporary geometry (GPKG) file to the tests and fixed the non-passing test in |
Perfect, the fixture looks good! |
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 72.50% 72.63% +0.12%
==========================================
Files 19 19
Lines 1575 1575
Branches 221 221
==========================================
+ Hits 1142 1144 +2
+ Misses 368 367 -1
+ Partials 65 64 -1
Continue to review full report at Codecov.
|
Closes #225 .
Change proposed in this Pull Request
Description
all_open(...)
andall_closed(...)
of the ExclusionContainer previously only considered rasters, not geometries in their logic.Motivation and Context
How Has This Been Tested?
Type of change
Checklist
pytest
inside the repository and no unexpected problems came up.doc/
.environment.yaml
file.doc/release_notes.rst
.pre-commit run --all
to lint/format/check my contribution