Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/exclusioncalculator filehandling #226

Merged
merged 7 commits into from
Mar 22, 2022

Conversation

euronion
Copy link
Collaborator

@euronion euronion commented Mar 21, 2022

Closes #225 .

Change proposed in this Pull Request

Description

all_open(...) and all_closed(...) of the ExclusionContainer previously only considered rasters, not geometries in their logic.

Motivation and Context

How Has This Been Tested?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [n/a] New feature (non-breaking change which adds functionality)
  • [n/a] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I tested my contribution locally and it seems to work fine.
  • I locally ran pytest inside the repository and no unexpected problems came up.
  • [n/a] I have adjusted the docstrings in the code appropriately.
  • [n/a ] I have documented the effects of my code changes in the documentation doc/.
  • [n/a] I have added newly introduced dependencies to environment.yaml file.
  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution

@euronion euronion requested a review from FabianHofmann March 21, 2022 08:08
Copy link
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@euronion thanks for taking care of this.

@euronion
Copy link
Collaborator Author

@FabianHofmann Can you have another look? I added a temporary geometry (GPKG) file to the tests and fixed the non-passing test in tests/test_gis.py

@FabianHofmann
Copy link
Contributor

Perfect, the fixture looks good!

@codecov-commenter
Copy link

Codecov Report

Merging #226 (3926acb) into master (f8a43d6) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 3926acb differs from pull request most recent head 1e79d8e. Consider uploading reports for the commit 1e79d8e to get more accurate results

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   72.50%   72.63%   +0.12%     
==========================================
  Files          19       19              
  Lines        1575     1575              
  Branches      221      221              
==========================================
+ Hits         1142     1144       +2     
+ Misses        368      367       -1     
+ Partials       65       64       -1     
Impacted Files Coverage Δ
atlite/gis.py 92.77% <100.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a43d6...1e79d8e. Read the comment docs.

@FabianHofmann FabianHofmann merged commit e3d0865 into master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shapefile path added through add_geometry not read when no rasters are provided
3 participants