Fix bad comparison for sarah datafiles. #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change proposed in this Pull Request
Fix a bad comparison when creating cutouts with SARAH2 data.
Previously if the cutout was to be created for e.g. an upper end of "2013-12-31 23:00" and the
sarah_dir
did only contain datafiles for 2013 (i.e. labelled "xxx20131223yyy.nc"), then the comparison failed and the error was thrown.This bug was not discovered because we had previously always downloaded multiple SARAH2 dataset years, i.e. more than 2013 were contained in the same directory and the bug did not surface.
Fixing this here.
How Has This Been Tested?
Locally. New cutout with SARAH data created.
Type of change
Checklist
pytest
inside the repository and no unexpected problems came up.doc/
.environment.yaml
file.doc/release_notes.rst
.pre-commit run --all
to lint/format/check my contribution