deprecate RustExtension.py_limited_api
#410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to simplify the
RustExtension
options a little further and remove thepy_limited_api
setting, as I think users should always use"auto"
and use[bdist_wheel]
configuration to set up an abi3 build.If the PyO3 module should be built in abi3 mode for local (i.e. non-wheel) builds too, then that configuration is probably better placed in the
Cargo.toml
than in thesetuptools-rust
layer.cc @alex as you implemented this setting originally, but I think
cryptography
has now also switched toauto
mode.