Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_lib_name #280

Merged
merged 2 commits into from
Aug 10, 2022
Merged

fix get_lib_name #280

merged 2 commits into from
Aug 10, 2022

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Aug 10, 2022

before it fails with TypeError: _metadata() missing 1 required positional argument: 'cargo'

tomtau and others added 2 commits August 10, 2022 12:26
before it fails with `TypeError: _metadata() missing 1 required positional argument: 'cargo'`
@davidhewitt
Copy link
Member

Thanks for opening this - I've pushed a changeling entry and a test to avoid this break again. Looks like mypy probably didn't catch this because of the @lru_cache decorator - that's unfortunate.

@davidhewitt davidhewitt merged commit 6d87a5b into PyO3:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants