Don't require optional wheel dependency. #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
approved these changes
Feb 11, 2021
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
jameshilliard
force-pushed
the
remove-wheel
branch
from
72a89ec to
fb62a82
Compare
Added to changelog. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to only be required for building binary wheels, so it should not be a hard requirement.
FYI I hit this issue when trying to port setuptools-rust to buildroot due to cryptography starting to require rust, buildroot deliberately does not support binary python wheels as python packages are cross compiled from source.