Add runtime dependency on setuptools #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
commented
Jan 14, 2021
| @@ -27,7 +27,7 @@ classifiers = | |||
| [options] | |||
| packages = setuptools_rust | |||
| zip_safe = True | |||
| install_requires = semantic_version>=2.6.0; toml>=0.9.0 | |||
| install_requires = setuptools>=46.1; semantic_version>=2.6.0; toml>=0.9.0 | |||
There was a problem hiding this comment.
Is 46.1 correct? I just copy and pasted the dependency from setup_requires.
By the way pyproject.toml specifies a different version.
There was a problem hiding this comment.
As 46.1 is the higher of the numbers, let's use that to be on the safe side.
If you're willing, could you please also update pyproject.toml so that they all match?
setuptools_rust has a runtime dependency on setuptools. Ensure that all installations of setuptools_rust have a sufficiently recent version of setuptools. Fixes: PyO3#101 Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
gh-101-setuptools
branch
from
6830479 to
f20d6e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools_rust has a runtime dependency on setuptools. Ensure that all
installations of setuptools_rust have a sufficiently recent version of
setuptools.
Fixes: #101
Signed-off-by: Christian Heimes christian@python.org