Break examples out of main workspace #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
adamreichold
force-pushed
the
examples-no-workspace
branch
from
245ade0 to
3a675b7
Compare
adamreichold
force-pushed
the
examples-no-workspace
branch
from
3a675b7 to
b54aed3
Compare
As features are unified over the whole of a workspace, having the examples inside the main workspace prevents independent tests of different combinations of PyO3 features. Therefore, this PR breaks them out into separate workspaces and adjust the xtask script to still include them where appropriate.
adamreichold
force-pushed
the
examples-no-workspace
branch
from
b54aed3 to
4ac7dfd
Compare
adamreichold
force-pushed
the
examples-no-workspace
branch
from
4ac7dfd to
3ef3f33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As features are unified over the whole of a workspace, having the examples inside the main workspace prevents independent tests of different combinations of PyO3 features. Therefore, this PR breaks them out into separate workspaces and adjust the xtask script to still include them where appropriate.