Update metadata in Cargo.toml #250
Conversation
There was a problem hiding this comment.
I know it is somewhat unrelated to this change, but since we are here: Is there a reason we have to forward ndarray's rayon feature, but not any other of its features, i.e.
[features]
default = []
rayon = ["ndarray/rayon"]? It does not seem to be used within our code base at all so I guess we could drop it and user code would have to enable any ndarray features in the same way, by adding an explicit dependency. (The other alternative would be to forward all of ndarray's features for consistency, but that feels like unnecessarily tight coupling.)
Cargo.toml
Outdated
| "Toshiki Teramura <toshiki.teramura@gmail.com>", | ||
| "Yuji Kanagawa <yuji.kngw.80s.revive@gmail.com>", | ||
| "The rust-numpy developers", | ||
| "PyO3 Project and Contributors <https://github.com/PyO3>" | ||
| ] | ||
| description = "Rust binding of NumPy C-API" |
There was a problem hiding this comment.
I think this is customarily called "Rust bindings" (plural)?
|
Agreed, it can be removed |
kngwyu
force-pushed
the
update-metadata-in-cargo-toml
branch
from
427a40d to
c72a60c
Compare
I think we can remove the whole |
|
I will add an example for #70 which will show case how to enable ndarray features... |
kngwyu
force-pushed
the
update-metadata-in-cargo-toml
branch
from
c72a60c to
08bb302
Compare
| @@ -24,9 +25,5 @@ pyo3 = { version = "0.15", default-features = false } | |||
| [dev-dependencies] | |||
| pyo3 = { version = "0.15", features = ["auto-initialize"] } | |||
|
|
|||
| [features] | |||
| default = [] | |||
| rayon = ["ndarray/rayon"] | |||
There was a problem hiding this comment.
Might be worth noting this removal in the CHANGELOG. (Alongside a suggestion to just use ndarrays feature directly).
kngwyu
force-pushed
the
update-metadata-in-cargo-toml
branch
from
08bb302 to
7e12778
Compare
adamreichold
force-pushed
the
update-metadata-in-cargo-toml
branch
from
7e12778 to
406b24e
Compare
|
@kngwyu I took the liberty of rebasing this and resolving the changelog conflict. If you alright with that, I'll merge this soon? |
|
Alright 👍 |
Since some contributors are not involved in PyO3 team (e.g., the original author @termoshtt), I employed dual authorship (rust-numpy and PyO3 developers).
Also, I updated the document link and added
categories.Let me know if you have any idea 😃