Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resolver argument from Cargo.toml #202

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

mtreinish
Copy link
Contributor

When building rust-numpy with the rust/cargo 1.48 packaged on Debian
bullseye the build fails because in Cargo 1.48 the resolver option was a
nightly only feature and Cargo errors. This feature wasn't stabilized
until 1.51. I think we aren't catching this in the MSRV jobs because
1.41 is old enough that the resolver option wasn't known.

When building rust-numpy with the rust/cargo 1.48 packaged on Debian
bullseye the build fails because in Cargo 1.48 the resolver option was a
nightly only feature and Cargo errors. This feature wasn't stabilized
until 1.51. I think we aren't catching this in the MSRV jobs because
1.41 is old enough that the resolver option wasn't known.
@adamreichold
Copy link
Member

Shouldn't this be a full revert of 7817be6 then? The original PR had

This saves a bunch of unnecessary dependencies when using rust-numpy as a dependency.

as its motivation. So this does sound like an optimisation, not a necessity. But to be sure, cc @m-ou-se ?

@m-ou-se
Copy link
Contributor

m-ou-se commented Aug 30, 2021

You can keep the dev-dependency/dependency split, but only remove the resolver = "2" part. (Exactly as this PR is doing.) Then, a project that uses pyo3-numpy can still pick resolver = "2" to benefit from the reduced number of dependencies and features.

@kngwyu
Copy link
Member

kngwyu commented Sep 14, 2021

Thanks!

You can keep the dev-dependency/dependency split, but only remove the resolver = "2" part. (Exactly as this PR is doing.) Then, a project that uses pyo3-numpy can still pick resolver = "2" to benefit from the reduced number of dependencies and features.

Sounds reasonable.

@kngwyu kngwyu merged commit 0ffe035 into PyO3:main Sep 14, 2021
@mtreinish mtreinish deleted the remove-resolver branch September 16, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants