Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #889 #920

Merged
merged 1 commit into from
May 12, 2020
Merged

Revert #889 #920

merged 1 commit into from
May 12, 2020

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented May 11, 2020

rust-numpy has a stub implementation of PyMethodsImpl, so it should not require inventory storage by default.

@kngwyu kngwyu mentioned this pull request May 11, 2020
Merged
@davidhewitt
Copy link
Member

Interesting... rust-numpy is making custom PyClass?

@kngwyu
Copy link
Member Author

kngwyu commented May 12, 2020

Interesting... rust-numpy is making custom PyClass?

Yeah, it has a PyClass that wraps Box<[T]> to avoid copy entire buffer.

@kngwyu kngwyu merged commit 956ed52 into PyO3:master May 12, 2020
@kngwyu kngwyu deleted the methods-impl-compat branch May 12, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kngwyu @davidhewitt