Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of #[pyo3(get, set)] with Py<T> #880

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Allow use of #[pyo3(get, set)] with Py<T> #880

merged 1 commit into from
Apr 23, 2020

Conversation

davidhewitt
Copy link
Member

Noticed support for this was missing after writing some comments for #877 .

@davidhewitt davidhewitt requested a review from kngwyu April 22, 2020 21:22
kngwyu
kngwyu reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 💯

@kngwyu kngwyu merged commit e9e0da5 into PyO3:master Apr 23, 2020
@davidhewitt davidhewitt deleted the py_get_set branch August 10, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @kngwyu