Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null in PyIterator::from_object to fix #494 #544

Closed
wants to merge 1 commit into from
Closed

Handle null in PyIterator::from_object to fix #494 #544

wants to merge 1 commit into from

Conversation

konstin
Copy link
Member

@konstin konstin commented Jul 17, 2019

No description provided.

kngwyu
kngwyu approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@konstin
Copy link
Member Author

konstin commented Jul 17, 2019

I don't understand why the 3.5 tests for the pr build on travis keep failing. They pass for the other travis build and also pass locally.

@kngwyu
Copy link
Member

kngwyu commented Jul 17, 2019

image
Hmm 🤔

@kngwyu
Copy link
Member

kngwyu commented Jul 17, 2019 •
edited
Loading

Removal of if ffi::PyIter_Check(ptr) != 0 looks the cause.

@konstin
Copy link
Member Author

konstin commented Jul 17, 2019

cpython calls PyIter_Check internally, and that code hasn't changed for 9 years: https://github.com/python/cpython/blob/82494aa6d947c4a320c09c58fe0f100cdcf7af0b/Objects/abstract.c#L2578

@kngwyu
Copy link
Member

kngwyu commented Jul 18, 2019

Sorry, then I have no idea

@konstin konstin mentioned this pull request Jul 19, 2019
Merged
@codecov
Copy link

codecov bot commented Jul 21, 2019 •
edited
Loading

Codecov Report

Merging #544 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   87.61%   87.64%   +0.02%     
==========================================
  Files          65       64       -1     
  Lines        3449     3441       -8     
==========================================
- Hits         3022     3016       -6     
+ Misses        427      425       -2
Impacted Files Coverage Δ
src/types/iterator.rs 93.33% <100%> (+5.09%) ⬆️
src/ffi3/objectabstract.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20534ec...9c1f42f. Read the comment docs.

@danieldk danieldk mentioned this pull request Jul 27, 2019
Merged
@konstin konstin closed this Aug 11, 2019
@konstin konstin deleted the fix_494 branch September 23, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konstin @kngwyu