Code

Trait ergonomics str implementation#4233

Code

Merged

Icxolu merged 47 commits intoPyO3:mainPyO3/pyo3:mainfrom Zyell:trait_ergonomics_strZyell/pyo3:trait_ergonomics_strCopy head branch name to clipboardJul 17, 2024

+794-84

Commits

Commits on Jun 4, 2024

• feat: Implement custom string formatting for PyClass

  Show description for 8e7c8c6
  

  Michael Gilbert

  committed
  8e7c8c6

• update: removed debug print statements

  

  Michael Gilbert

  committed
  a058296

• update: added members to ToTokens implementation.

  

  Michael Gilbert

  committed
  0b4ddbc

• update: reverted to display

  

  Michael Gilbert

  committed
  1f3bb49

• update: initial tests

  

  Michael Gilbert

  committed
  ae28b72

• update: made STR public for pyclass default implementations

  

  Michael Gilbert

  committed
  f3ebabe

• update: generalizing str implementation

  

  Michael Gilbert

  committed
  51d52c1

• update: remove redundant test

  

  Michael Gilbert

  committed
  fcd51a0

• update: implemented compile test to validate that manually implemented str is not allowed when automated str is requested

  

  Michael Gilbert

  committed
  804f81e

• update: updated compile time error check

  

  Michael Gilbert

  committed
  a9b6d5e

• update: rename test file and code cleanup

  

  Michael Gilbert

  committed
  e7fd6bd

• update: format cleanup

  

  Michael Gilbert

  committed
  d6a3ac6

• update: added news fragment

  

  Michael Gilbert

  committed
  02f2202

Commits on Jun 5, 2024

• fix: corrected clippy findings

  

  Michael Gilbert

  committed
  c075611

• update: fixed mixed formatting case and improved test coverage

  

  Michael Gilbert

  committed
  5297915

• update: improved test coverage

  

  Michael Gilbert

  committed
  c940310

• refactor: generalized formatting function to accommodate __repr__ in a future implementation since it will use the same shorthand formatting logic

  

  Michael Gilbert

  committed
  4059225

• update: Add support for rename formatting in PyEnum3

  Show description for 0ce912f
  

  Michael Gilbert

  committed
  0ce912f

• fix: fixed clippy finding

  

  Michael Gilbert

  committed
  0c33be0

Commits on Jun 6, 2024

• update: fixed test function names

  

  Michael Gilbert

  committed
  9b89c40

• Update pyo3-macros-backend/src/pyclass.rs

  Show description for d8cd29a
  

  Zyell

  and

  mejrs

  authored
  d8cd29a

• Update newsfragments/4233.added.md

  Show description for 9d8b170
  

  Zyell

  and

  mejrs

  authored
  9d8b170

• update: implemented hygienic calls and added hygiene tests.

  

  Michael Gilbert

  committed
  23b0b8f

• update: cargo fmt

  

  Michael Gilbert

  committed
  c653bef

• update: retained LitStr usage in the quote in order to preserve a more targeted span for the format string.

  

  Michael Gilbert

  committed
  f8d1be3

• update: retained LitStr usage in the quote in order to preserve a more targeted span for the format string.

  

  Michael Gilbert

  committed
  6e77f9d

Commits on Jun 7, 2024

• update: added compile time error check for invalid fields (looking to reduce span of invalid member)

  

  Michael Gilbert

  committed
  9f51d47

• update: implemented a subspan to improve errors in format string on nightly, verified additional test cases on both nightly and stable

  

  Michael Gilbert

  committed
  12eb032

• update: updated test output

  

  Michael Gilbert

  committed
  4d0e738

• update: updated with clippy findings

  

  Michael Gilbert

  committed
  f4a223f

• update: added doc entries.

  

  Michael Gilbert

  committed
  cc1317c

• Merge branch 'refs/heads/main' into trait_ergonomics_str

  Show description for 8d73c33
  

  Michael Gilbert

  committed
  8d73c33

• update: corrected error output for compile errors after updating from main.

  

  Michael Gilbert

  committed
  678208e

Commits on Jun 10, 2024

• update: added support for raw identifiers used in field names

  

  Michael Gilbert

  committed
  1f84dd3

Commits on Jun 25, 2024

• Merge branch 'refs/heads/main' into trait_ergonomics_str

  Show description for d0e7287
  

  Michael Gilbert

  committed
  d0e7287

• update: aligning branch with main

  

  Michael Gilbert

  committed
  e9e149d

• update: added compile time error when mixing rename_all or name pyclass, field, or variant args when mixed with a str shorthand formatter.

  

  Michael Gilbert

  committed
  0137083

Commits on Jul 15, 2024

• Merge branch 'refs/heads/main' into trait_ergonomics_str

  

  MG

  committed
  a49249e

Commits on Jul 16, 2024

• Merge branch 'refs/heads/main' into trait_ergonomics_str

  

  MG

  committed
  5cc07da

• update: removed self option from str format shorthand, restricted str shorthand format to structs only, updated docs with changes, refactored renaming incompatibility check with str shorthand.

  

  MG

  committed
  1597175

• update: removed checks for shorthand and renaming for enums and simplified back to inline check for structs

  

  MG

  committed
  5709b85

Commits on Jul 17, 2024

• update: added additional test case to increase coverage in match branch

  

  MG

  committed
  ba234b2

• fix: updated pyclass heighten check to validate for eq and ord, fixing Ok issue in eq implementation.

  

  MG

  committed
  a37c24b

• Revert "fix: updated pyclass heighten check to validate for eq and ord, fixing Ok issue in eq implementation."

  Show description for 35f1ed9
  

  MG

  committed
  35f1ed9

• update: improved error comments, naming, and added reference to the PR for additional details regarding the implementation of str

  

  MG

  committed
  5f1b285

• Merge branch 'refs/heads/main' into trait_ergonomics_str

  Show description for 873ac6c
  

  MG

  committed
  873ac6c

• update: fixed merge conflict

  

  MG

  committed
  dc09612