Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gil-refs feature to aid migration #3707

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

davidhewitt
Copy link
Member

As proposed in #3681 (comment), this PR adds a feature which in 0.21 will disable deprecation warnings related to the to-be-removed GIL Refs API.

@adamreichold: we were using the name pool in that discussion, however I felt I liked gil-refs slightly more as the users don't typically interact with the GILPool, however the GIL Refs as a concept are very user-facing. If you have a strong preference for the feature to be called pool I can rename to that.

In PyO3 0.22 we can make this migration stricter by gating the GIL Refs API behind this feature, and emitting deprecation warnings even when this feature is enabled.

Finally in 0.23 or 0.24 we remove this feature and the accompanying APIs.


I have also pushed an accompanying second commit which is an updated copy of #3693 to begin the migration guide entry for this feature.

@davidhewitt davidhewitt added this pull request to the merge queue Dec 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 29, 2023
@davidhewitt
Copy link
Member Author

I'll push rust 1.75 updates shortly!

@davidhewitt davidhewitt added this pull request to the merge queue Dec 29, 2023
Merged via the queue into PyO3:main with commit 6776b90 Dec 29, 2023
37 checks passed
@davidhewitt davidhewitt deleted the gil-refs-feature branch December 29, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants