Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some api improvements #367

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Some api improvements #367

merged 3 commits into from
Feb 23, 2019

Conversation

konstin
Copy link
Member

@konstin konstin commented Feb 23, 2019

No description provided.

@konstin konstin merged commit 3067b7b into master Feb 23, 2019
@konstin konstin deleted the restructuring branch February 23, 2019 17:59
@konstin konstin mentioned this pull request Feb 23, 2019
Closed
@kngwyu
Copy link
Member

kngwyu commented Feb 24, 2019

Is PyManagedRef meant to enable users to avoid selecting as_ptr and to_object manually?
If so, it seems a too complex solution to me:thinking:

@konstin
Copy link
Member Author

konstin commented Feb 24, 2019

You can't select that manually because you can't tell if the object even has a as_ptr and always calling to_object is imho worse. The trait is essentially java's instanceof for a specific, and I fear it's not possible to do this more straightforward without specialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konstin @kngwyu