Change return types of py.None(), py.NotImplemented() and py.Ellipsis() to typed singletons
#3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
typed-helpers
branch
3 times, most recently
from
3856c51
to
bd0174a
Compare
…ipsis()` to typed singletons
messense
approved these changes
Nov 20, 2023
wyfo
pushed a commit
to wyfo/pyo3
that referenced
this pull request
Nov 20, 2023
This was referenced Feb 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2024
Revert "Merge pull request #3578 from davidhewitt/typed-helpers"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
py.None()to return&PyNonepy.NotImplemented()to return&PyNotImplementedpy.Ellipsis()to return&PyEllipsisThis was discussed in #3577 (comment) where it was suggested there was no needed to make this a standalone PR. I decided to break it out anyway as this is a change that may create some small breakages for users, so I wanted to make the diff for this more visible (and show how PyO3 code adjusted to it), as well as make a migration guide entry for it.