-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion support for either::Either
#3456
Conversation
16be081
to
f78a00e
Compare
775579a
to
5f77a05
Compare
Btw the errors that appear on CI:
I was also seeing locally (on M1), was assuming it's some local problem, but apparently not... |
You might be seeing fallout from #3424. |
5f77a05
to
6e64b1e
Compare
Yes I'm working on a pr to fix the chrono problem, will try to push later |
6e64b1e
to
bcaf63c
Compare
bcaf63c
to
a75464e
Compare
CodSpeed Performance ReportMerging #3456 will improve performances by 22.57%Comparing Summary
Benchmarks breakdown
|
Added conversion support for
either
'sEither<L, R>
type, equivalent toUnion[L, R]
on the Python side.It's a tiny but pretty popular crate, with 24k dependent crates and 6-7M downloads/m.
It also simplifies a very common use case of accepting or returning one of the two types, without having to define a helper enum for each particular case.