add --no-fail-fast to cargo test in CI #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
approved these changes
Sep 8, 2023
davidhewitt
force-pushed
the
test-no-fail-fast
branch
from
f4da30d to
6f6075a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be helpful when changes break multiple tests, or e.g. in #3430 when adding a new test job I'd like to see everything that is broken.
Upside is that all test failures are reported, so fewer pushes & CI runs may be needed overall to fix them.
Downside is that the failures are higher up the log, so scrolling needed to see the test break.
On balance I think this is worth it.