Extend guide section on classes regarding free functions #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
reviewed
Jun 15, 2023
There was a problem hiding this comment.
Thanks for adding this section! It's actually been on my mind for a long time, see #1059. I just never got around to writing anything 🙈. Do you think this PR closes that issue?
It might not be obvious from the reading the sections on free functions and on classes that they combine in a frictionless manner, i.e. class instances can be parameters to free functions in the same manner that the self parameters of instance methods are handled. This also explicitly calls out the interaction between `Clone` and `FromPyObject` for classes.
I added taking |
adamreichold
force-pushed
the
classes-and-free-functions
branch
from
7a0b6d2 to
4470a1f
Compare
davidhewitt
approved these changes
Jun 16, 2023
adamreichold
force-pushed
the
classes-and-free-functions
branch
from
4470a1f to
684002d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might not be obvious from the reading the sections on free functions and on classes that they combine in a frictionless manner, i.e. class instances can be parameters to free functions in the same manner that the self parameters of instance methods are handled.
This also explicitly calls out the interaction between
CloneandFromPyObjectfor classes.Closes #1059
cc @facundo-villa