Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BigInt conversion for PyPy #2626

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Enable BigInt conversion for PyPy #2626

merged 3 commits into from
Sep 20, 2022

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Sep 16, 2022

BigInt conversion seems to have been disabled for PyPy due to lack of support for needed functionality at the time it was implemented. Just enabling it seems to work out of the box now. Tested with PyPy 3.7-7.3.9 via REPL.

@davidhewitt
Copy link
Member

👍 just needs release notes added please, newsfragments/2626.added.md

Maybe the below:

Add support for `num-bigint` feature on `PyPy`.

@messense messense merged commit d72989f into PyO3:main Sep 20, 2022
davidhewitt pushed a commit that referenced this pull request Sep 29, 2022
* Enable bigint conversion for PyPy

* Update src/conversions/num_bigint.rs

* Add a changelog entry for PyPy `num-bigint` support

Co-authored-by: messense <messense@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants