ffi: cleanup sliceobject #1866
ffi: cleanup sliceobject #1866
Conversation
src/types/slice.rs
Outdated
| @@ -61,6 +61,7 @@ impl PySlice { | |||
| let start: isize = 0; | |||
| let stop: isize = 0; | |||
| let step: isize = 0; | |||
| #[allow(deprecated)] | |||
| let r = ffi::PySlice_GetIndicesEx( | |||
There was a problem hiding this comment.
What's the recommended replacement to using PySlice_GetIndicesEx? It would be great to remove this usage of a deprecated API...
There was a problem hiding this comment.
In cpython, they define a macro PySlice_GetIndicesEx (shown below)
#define PySlice_GetIndicesEx(slice, length, start, stop, step, slicelen) ( \
PySlice_Unpack((slice), (start), (stop), (step)) < 0 ? \
((*(slicelen) = 0), -1) : \
((*(slicelen) = PySlice_AdjustIndices((length), (start), (stop), *(step))), \
0))Which I didn't implement since currently we didn't have PySlice_Unpack and PySlice_AdjustIndices.
These method seems not so hard. If you like, I can also implement these.
There was a problem hiding this comment.
That would be great, yes please!
Given the function is deprecated in Python 3.7, and there's quite a complex condition on the macro, PySlice_Unpack and PySlice_AdjustIndices which suggest they were added in Python 3.6.1, I think we can only use the new macro form in Python 3.7 and up.
deantvv
force-pushed
the
ffi-cleanup-sliceobject
branch
from
6c44b98
to
e67338b
Compare
deantvv
force-pushed
the
ffi-cleanup-sliceobject
branch
from
e67338b
to
126df61
Compare
|
Perfect, thanks again! |
For #1289