Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: refactor for simplicity #1574

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

davidhewitt
Copy link
Member

This is a collection of a few small refactorings to build.rs:

  • Made the error message slightly nicer when accidentally compiling on a Python version which is too old.
  • Moved BuildFlags struct inside the InterpreterConfig, which I think is logically correct.
  • The abi3_without_interpreter configuration now uses the same code path to emit cargo configuration as the rest of the script. This is motivated by changes in Add support for arbitrary arrays #1128 where I noticed the configure_const_generics() call was nearly missed out of the abi3_without_interpreter function, which would have led to confusing bugs.
  • A few other minor updates to comments which had gotten very stale.

@davidhewitt
Copy link
Member Author

CI failure looks like rust-lang/rust#84502 - I think we may have to live with coverage job being down for the next few days...

@davidhewitt davidhewitt merged commit b365969 into PyO3:main Apr 26, 2021
@davidhewitt davidhewitt deleted the build-script-refactor branch April 26, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant