Check buffer protocol support before getting buffer in sequence protocol specialization #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…col specialization This avoids calling a expensive `PyErr_Format` inside of `PyObject_GetBuffer` when buffer protocol is unsupported
davidhewitt
reviewed
Mar 16, 2021
There was a problem hiding this comment.
Minor further suggestion.
Also tbh I'm not a fan of the nightly feature and probably wouldn't recommend it for users trying to get performance. Specialization is known to have soundness holes; I don't know if it's possible for users to hit them with our unstable implementations but I don't want to have to debug that 😅
davidhewitt
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids calling a expensive
PyErr_Formatinside ofPyObject_GetBufferwhen buffer protocol is unsupported