Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add detail to wrapper type conversions #1157

Merged
merged 1 commit into from
Sep 6, 2020

Conversation

davidhewitt
Copy link
Member

I took a look at writing a table for #376. This table ended up being big and confusing, and also not possible to doctest. So in the end I decided it was better to extend the existing examples on types.md.

At the same time I also made the language more consistent and simpler.

Now every example is of the same format, e.g.

// To &PyList with PyAny::downcast
let _: &PyList = any.downcast()?;

Closes #376

Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge this at your own convenience.

Copy link
Member

@birkenfeld birkenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidhewitt davidhewitt merged commit a1d6c7a into PyO3:master Sep 6, 2020
@davidhewitt davidhewitt deleted the conversion-detail branch August 10, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Table with conversions between wrapper types
3 participants