Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[text_signature] doesn't work with abi3 #1288

Closed
davidhewitt opened this issue Nov 20, 2020 · 0 comments · Fixed by #1318
Closed

#[text_signature] doesn't work with abi3 #1288

davidhewitt opened this issue Nov 20, 2020 · 0 comments · Fixed by #1318
Labels
Milestone

Comments

@davidhewitt
Copy link
Member

The solution in #1201 for text_signature with abi3 got disabled until Python 3.10, so at the moment I think __text_signature__ will just silently be None if abi3 is enabled.

We might want to consider a more user-friendly solution like failing at compile-time.

Not sure if this blocks 0.13 release - I think it's potentially quite annoying but also I expect no users are using abi3 yet, so it'll only break for them when they switch to abi3.

At the very least we should document the problem alongside abi3 docs before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant