Skip to content

[FTPFS] Handle EOFError #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2019
Merged

[FTPFS] Handle EOFError #315

merged 3 commits into from
Jul 28, 2019

Conversation

dargueta
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Catch EOFError if thrown by an FTP operation and re-raise it as a RemoteConnectionError.
Closes #292.

@dargueta dargueta changed the title Handle EOFError (closes #292) [FTPFS] Handle EOFError Jul 26, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 99.078% when pulling aea8d46 on dargueta:ftp-eoferror into 37b46b4 on PyFilesystem:master.

@willmcgugan
Copy link
Member

Thanks

@willmcgugan willmcgugan merged commit 3723642 into PyFilesystem:master Jul 28, 2019
@dargueta dargueta deleted the ftp-eoferror branch July 29, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FTPFS: EOFError in listdir
3 participants
@dargueta @coveralls @willmcgugan