Use pip-api instead of importing pip #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests were being skipped unnecessarily. The skips were added in PyCQA#809.
The ordering of the found requirements isn't important here
Codecov Report
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
+ Coverage 89.03% 89.17% +0.13%
===========================================
Files 8 8
Lines 2417 2410 -7
Branches 433 433
===========================================
- Hits 2152 2149 -3
+ Misses 178 174 -4
Partials 87 87 |
|
Looks perfect, thank you so much! |
timothycrosley
added a commit
that referenced
this pull request
Apr 18, 2019
Use pip-api instead of importing pip
belm0
reviewed
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #924.
Also removes some (seemingly?) unnecessary
@pytest.mark.skipifdecorators that were preventing the relevant tests from being run.