Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Safety #2373

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Remove Safety #2373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/contributing/1.-contributing-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ Base System Requirements:
Once you have verified that your system matches the base requirements you can start to get the project working by following these steps:

1. [Fork the project on GitHub](https://github.com/pycqa/isort/fork).
2. Clone your fork to your local file system:
1. Clone your fork to your local file system:
`git clone https://github.com/$GITHUB_ACCOUNT/isort.git`
3. `cd isort`
4. `uv sync --all-extras --frozen`
1. `cd isort`
1. `uv sync --all-extras --frozen`
* Optionally, isolate uv's installation from the rest of your system using the instructions on the uv site here: https://docs.astral.sh/uv/
5. `./scripts/test.sh` should yield Success: no issues found
6. `./scripts/clean.sh` should yield a Safety report checking packages
1. `./scripts/test.sh` should yield Success: no issues found
1. `./scripts/clean.sh` should yield a report checking packages
Comment on lines +25 to +31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to keep the numbers here 😄

Copy link
Collaborator Author

@staticdev staticdev Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielNoord a cool feature of Markdown is putting 1. to everything, it will automatically put the order for you. This makes easier to maintain and add other items to the list. But if you prefer I can revert it since it is not really related to Safety.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL


**TIP**: `./scripts/done.sh` will run both clean and test in one step.

Expand Down
1 change: 0 additions & 1 deletion docs/contributing/2.-coding-standard.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,3 @@ All code submitted to hug should run through the following tools:
- ruff
- pep8-naming
- vulture
- safety
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ dev = [
"pytest-mock>=1.10",
"requirementslib>=1.5",
"ruff>=0.9.6",
"safety>=2.2.0",
"stdlibs>=2024.10.21.16",
"toml>=0.10.2",
"types-colorama>=0.4.2",
Expand Down
3 changes: 0 additions & 3 deletions scripts/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,4 @@ uv run isort --profile hug --check --diff isort/ tests/
uv run isort --profile hug --check --diff example_*/
uv run --with=Flake8-pyproject flake8 isort/ tests/
uv run ruff check
# 51457: https://github.com/tiangolo/typer/discussions/674
# 72715: https://github.com/timothycrosley/portray/issues/95
uv run safety check -i 72715 -i 51457 -i 59587
uv run bandit -r isort/ -x isort/_vendored
Loading
Loading