Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as imports removed when --combine-star is set #1380

Closed
timothycrosley opened this issue Aug 13, 2020 · 2 comments · Fixed by #1410
Closed

as imports removed when --combine-star is set #1380

timothycrosley opened this issue Aug 13, 2020 · 2 comments · Fixed by #1410
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone
5.5.0

Comments

@timothycrosley
Copy link
Member

Currently, as imports will be removed, if a star import is present from the same module and --combine-star is enabled. This will likely break code that depends on the import aliasing.
@timothycrosley timothycrosley added bug Something isn't working help wanted Extra attention is needed labels Aug 13, 2020
@timothycrosley timothycrosley mentioned this issue Aug 13, 2020
Merged
@Jackenmen
Copy link

Jackenmen commented Aug 13, 2020 •
edited
Loading

@timothycrosley should this be closed after #1376 got merged (and 5.4.0 released)?

Edit: I guess the release description (and changelog) of 5.4.0 is just mentioning wrong issue.

@timothycrosley timothycrosley added this to the 5.5.0 milestone Aug 15, 2020
@timothycrosley
Copy link
Member Author

@jack1142 Thanks for the note! I've updated the changelog to point to the correct issue.

~Timothy

timothycrosley added a commit that referenced this issue Aug 26, 2020
@timothycrosley
Initial fix for #1380: dont combine as into star as it will change ap…
b217412 
…plication functionality
@timothycrosley timothycrosley mentioned this issue Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
5.5.0
Development

Successfully merging a pull request may close this issue.

Issue/1380/dont combine as into star PyCQA/isort
2 participants
@timothycrosley @Jackenmen