Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B909 improvements #460

Merged
merged 4 commits into from
Feb 14, 2024
Merged

B909 improvements #460

merged 4 commits into from
Feb 14, 2024

Conversation

mimre25
Copy link
Contributor

@mimre25 mimre25 commented Feb 8, 2024

image

ahh... nothing better than the classic "next week" that turns into a month 😅

This implements all improvements listed in #454.

I've implemented a rather "simple" check for unconditional breaks.
I believe if we want to catch all scenarios, we'll eventually end up with the reachability problem, at least it feels like we're getting close to it.

This splits the convoluted test files into clearer categories of what is
being tested.
Previously I had the test file contain semantically correct code, that
would also run just fine, except for the errors.
I scratched that idea now to aid the readability and understandability
of the test file.
@mimre25 mimre25 changed the title B038 improvements B909 improvements Feb 8, 2024
This commit takes care of detecting mutations stemming from
AugAssign and Assign.
Also removes incorrect detection of "del foo".
@mimre25 mimre25 marked this pull request as ready for review February 10, 2024 14:26
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting around to it! All looks good to me using tests to see what we flag on.

@cooperlees cooperlees merged commit 6bf907c into PyCQA:main Feb 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants