Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 3.6 specific code in test_functional.py #800

Closed
ericwb opened this issue Feb 6, 2022 · 0 comments · Fixed by #802
Closed

Remove Python 3.6 specific code in test_functional.py #800

ericwb opened this issue Feb 6, 2022 · 0 comments · Fixed by #802
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ericwb
Copy link
Member

ericwb commented Feb 6, 2022

Describe the bug

Python 3.6 support was dropped since 3.6 is end-of-life. Yet test_functional.py still has conditional logic based
on Python 3.6. See https://github.com/PyCQA/bandit/blob/master/tests/functional/test_functional.py#L389

Reproduction steps

1. View https://github.com/PyCQA/bandit/blob/master/tests/functional/test_functional.py#L389

Expected behavior

No longer necessary to support Python 3.6 conditional code.

Bandit version

1.7.2 (Default)

Python version

3.9

Additional context

No response
@ericwb ericwb added bug Something isn't working good first issue Good for newcomers labels Feb 6, 2022
@ericwb ericwb mentioned this issue Feb 7, 2022
Merged
lukehinds pushed a commit that referenced this issue Feb 7, 2022
@ericwb
Remove redundant Python 3.6 code (#802)
9131162 
Bandit no longer supports Pytyon 3.6 and earlier since those are
end-of-life. Therefore there is no longer a need to have any
code that conditional checks on versions as early as that.

This change cleans up the sql_statements check to only be for
Python 3.7 and later.

Closes #800

Signed-off-by: Eric Brown <browne@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant Python 3.6 code
1 participant
@ericwb