Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing some readability issues. #75

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Fixing some readability issues. #75

merged 1 commit into from
Aug 23, 2020

Conversation

hadialqattan
Copy link
Contributor

@hadialqattan hadialqattan commented Aug 14, 2020 •
edited
Loading

  • on standard_paths function:

    • I used os.path.isdir instead of try: ... except OSError: pass for checking if lib-dynload exists.

  • on standard_package_names function:

    • I used name.endswith instead of using the complex expression name.rsplit('.')[-1]

@hadialqattan
Fixing some readability issues.
3d0346a 
- on standard_paths function:
    * I used `os.path.isdir` instead of `try: ... except OSError: pass`  for checking if `lib-dynload` exist.

- on  `standard_package_names` function:
    * I used `name.endswith` instead of using the complex expression `name.rsplit('.')[-1]`
@coveralls
Copy link

coveralls commented Aug 14, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0006%) to 99.438% when pulling 3d0346a on hadizakialqattan:patch-2 into b330072 on myint:master.

myint
myint approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@myint myint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@myint myint merged commit 22b0a69 into PyCQA:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myint myint myint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hadialqattan @coveralls @myint