Fix multiline import statements (proposal for issue #8) #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such as: - leading/trailing commas/line continuation - try/except - semicolon - empty imports as result In some cases the approach of "not changing anything if it is too risk" was adopted (as already happens in other parts of the code).
Unfortunately treating inline comments inside imports increases the complexity in the implementation. This change reduces complexity by refusing to change multiline import statements that contain comments. This approach is also used in other parts of the code.
... By using the existing code as a template.
|
Thanks! I'll have to review this in more detail when I get a chance. |
|
@myint Please review this MR and merge whenever possible. This should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @myint. Thank you very much for creating this awesome project.
This PR is my proposal on how to close #8. I hope you find it relevant.
It still skips difficult scenarios like lines joined by a semicolon, inline try-catch, comments and etc, but I think tackling everything would increase the complexity of the code to an undesired level.