Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newline after printing "No issues detected" during check mode #53

Merged
merged 2 commits into from
Jun 2, 2019

Conversation

sargun
Copy link
Contributor

@sargun sargun commented May 28, 2019

In check mode, we print "No issue detected" after checking a file, and if that file contains no errors. This leads to lines like:

No issues detected!No issues detected!No issues detected!

Add a \n to make this slightly better.

sargun and others added 2 commits May 28, 2019 09:49
In check mode, we print "No issue detected" after checking a file, and if that file contains no errors. This leads to lines like:

No issues detected!No issues detected!No issues detected!

Add a \n to make this slightly better.
Copy link
Member

@myint myint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@myint myint merged commit efcda0c into PyCQA:master Jun 2, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.324% when pulling 7a3c5ca on sargun:patch-2 into 68fea68 on myint:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.324% when pulling 7a3c5ca on sargun:patch-2 into 68fea68 on myint:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.324% when pulling 7a3c5ca on sargun:patch-2 into 68fea68 on myint:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.324% when pulling 7a3c5ca on sargun:patch-2 into 68fea68 on myint:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.324% when pulling 7a3c5ca on sargun:patch-2 into 68fea68 on myint:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.324% when pulling 7a3c5ca on sargun:patch-2 into 68fea68 on myint:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants