Always set encoding when reading setup.cfg
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsouza
force-pushed
the
setup.cfg-set-encoding
branch
2 times, most recently
from
cd47dce to
ae5d358
Compare
This should fix an issue on Window where the `setup.cfg` can contain non-ascii characters, and Python is trying to use cp1252. This should be safe as utf-8 is compatible with cp1252. It's possible I'll eat my words and some other platform breaks with this change, but let's try. Closes #294.
fsouza
force-pushed
the
setup.cfg-set-encoding
branch
from
ae5d358 to
2f53416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix an issue on Window where the
setup.cfgcan contain non-ascii characters, and Python is trying to use cp1252. This should be safe as utf-8 is compatible with cp1252.It's possible I'll eat my words and some other platform breaks with this change, but let's try.
Closes #294.