Use regular dictionary instead of defaultdict #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsouza
force-pushed
the
fix-lambda-error
branch
2 times, most recently
from
1b35eb5 to
1bf1f6c
Compare
fsouza
changed the title
fsouza
force-pushed
the
fix-lambda-error
branch
3 times, most recently
from
b5bf6f2 to
bc630ca
Compare
This makes sure that we don't break multiprocessing. Also introduce a test to prevent future regressions. I should have added that test ages ago :) Use --check and check just the exit status to avoid a flaky output. I'll investigate that later, for now, let's make sure we fix the buggy release. Closes #163.
fsouza
force-pushed
the
fix-lambda-error
branch
from
bc630ca to
eecb1cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that we don't break multiprocessing. Also introduce a
test to prevent future regressions. I should have added that test ages
ago :)
Closes #163.