Expand from foo import * for a single star import #14
Labels
Comments
adhikasp
added a commit
to adhikasp/autoflake
that referenced
this issue
Jun 12, 2017
adhikasp
added a commit
to adhikasp/autoflake
that referenced
this issue
Jun 15, 2017
This patch add new feature to automatically expand a star (wildcard) import to specify all names that used inside the code. A sample code like this ```python from math import * sin(1) cos(0) ``` will be changed into ```python from math import cos, sin sin(1) cos(0) ``` Note that there are still 2 bugs regarding this feature, which mainly caused by related upstream bug from pyflakes: 1. A function/names that declared but later deleted by `del` command will raise a false positive that the names is undeclared and could possibly come from a star import (if present). PyCQA/pyflakes#175 2. pyflakes is "inconsistent" on defining an undefined var in case of __all__ is used (like in module API files). ```python from foo import * # contain function_1 and function_2 __all__ = ['function_1', 'function_2', 'function_3'] function_2() # just use it somewhere to trigger pyflake def function_3: return 'something' ``` pyflakes will complain that function_2 is undefined and possibly come from module foo. The import then will be expanded into... ```python from foo import function_2 ``` But then pyflakes will complain function_1 is undefined because its used in `__all__` Closes PyCQA#14
adhikasp
added a commit
to adhikasp/autoflake
that referenced
this issue
Jun 15, 2017
This patch add new feature to automatically expand a star (wildcard) import to specify all names that used inside the code. A sample code like this ```python from math import * sin(1) cos(0) ``` will be changed into ```python from math import cos, sin sin(1) cos(0) ``` Note that there are still 2 bugs regarding this feature, which mainly caused by related upstream bug from pyflakes: 1. A function/names that declared but later deleted by `del` command will raise a false positive that the names is undeclared and could possibly come from a star import (if present). PyCQA/pyflakes#175 2. pyflakes is "inconsistent" on defining an undefined var in case of __all__ is used (like in module API files). ```python from foo import * # contain function_1 and function_2 __all__ = ['function_1', 'function_2', 'function_3'] function_2() # just use it somewhere to trigger pyflake def function_3: return 'something' ``` pyflakes will complain that function_2 is undefined and possibly come from module foo. The import then will be expanded into... ```python from foo import function_2 ``` But then pyflakes will complain function_1 is undefined because its used in `__all__` Closes PyCQA#14
adhikasp
added a commit
to adhikasp/autoflake
that referenced
this issue
Jun 16, 2017
This patch add new feature to automatically expand a star (wildcard) import to specify all names that used inside the code. A sample code like this ```python from math import * sin(1) cos(0) ``` will be changed into ```python from math import cos, sin sin(1) cos(0) ``` Note that there are still 2 bugs regarding this feature, which mainly caused by related upstream bug from pyflakes: 1. A function/names that declared but later deleted by `del` command will raise a false positive that the names is undeclared and could possibly come from a star import (if present). PyCQA/pyflakes#175 2. pyflakes is "inconsistent" on defining an undefined var in case of __all__ is used (like in module API files). ```python from foo import * # contain function_1 and function_2 __all__ = ['function_1', 'function_2', 'function_3'] function_2() # just use it somewhere to trigger pyflake def function_3: return 'something' ``` pyflakes will complain that function_2 is undefined and possibly come from module foo. The import then will be expanded into... ```python from foo import function_2 ``` But then pyflakes will complain function_1 is undefined because its used in `__all__` Closes PyCQA#14
adhikasp
added a commit
to adhikasp/autoflake
that referenced
this issue
Jun 16, 2017
This patch add new feature to automatically expand a star (wildcard) import to specify all names that used inside the code. A sample code like this ```python from math import * sin(1) cos(0) ``` will be changed into ```python from math import cos, sin sin(1) cos(0) ``` Note that there are still 2 bugs regarding this feature, which mainly caused by related upstream bug from pyflakes: 1. A function/names that declared but later deleted by `del` command will raise a false positive that the names is undeclared and could possibly come from a star import (if present). PyCQA/pyflakes#175 2. pyflakes is "inconsistent" on defining an undefined var in case of __all__ is used (like in module API files). ```python from foo import * # contain function_1 and function_2 __all__ = ['function_1', 'function_2', 'function_3'] function_2() # just use it somewhere to trigger pyflake def function_3: return 'something' ``` pyflakes will complain that function_2 is undefined and possibly come from module foo. The import then will be expanded into... ```python from foo import function_2 ``` But then pyflakes will complain function_1 is undefined because its used in `__all__` Closes PyCQA#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If there is only one star import,
from foo import *can be fixed by replacing the*with any undefined names.This would ideally be done by using
StarImportationandImportStarUsagewhich were introduced PyCQA/pyflakes@0532189b3 (v1.1.0).The text was updated successfully, but these errors were encountered: