Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] DND 3.0 compatibility #50

Closed
2 tasks done
PwQt opened this issue Jan 31, 2024 · 3 comments · Fixed by #53
Closed
2 tasks done

[Feature] DND 3.0 compatibility #50

PwQt opened this issue Jan 31, 2024 · 3 comments · Fixed by #53
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@PwQt
Copy link
Owner

PwQt commented Jan 31, 2024

As the name suggests - verify compatibility and if is not, then fix it.

If anyone reads this issue and finds any bug, please make a comment, i'll add it to main comment

Tested functionalities:

  • Adding/removing spells from magic items works, the tab seems to behave correctly - as intended, since it wasn't changed by dnd5e 3.0
  • Adjusted templates to work on the new sheet without breaking previous version compatibilities

Possible compatibility issues:

Currently found issues:

@PwQt PwQt added bug Something isn't working enhancement New feature or request labels Jan 31, 2024
@PwQt PwQt added this to the 2.0 milestone Jan 31, 2024
@PwQt PwQt added this to Magic Items Jan 31, 2024
@PwQt PwQt moved this to Task in Magic Items Jan 31, 2024
@PwQt PwQt moved this from Task to In Progress in Magic Items Jan 31, 2024
@PwQt
Copy link
Owner Author

PwQt commented Feb 1, 2024

Spells do not render, because of magicitemsheet.js

  async renderTemplate(name, cls, tab) {
    let template = await renderTemplate(`modules/${CONSTANTS.MODULE_ID}/templates/${name}.html`, this.actor);
    let el = this.html.find(`.${cls}`);
    if (el.length) {
      el.replaceWith(template);
    } else {
      this.html.find(`.${tab} .inventory-list`).append(template);
    }
  }

It seems like the .find method does not find correct element to append template.

@PwQt PwQt modified the milestones: 2.0, 1.6.0 Feb 1, 2024
@PwQt PwQt self-assigned this Feb 1, 2024
PwQt added a commit that referenced this issue Feb 1, 2024
PwQt added a commit that referenced this issue Feb 10, 2024
@PwQt PwQt moved this from In Progress to Testing in Magic Items Feb 10, 2024
@PwQt
Copy link
Owner Author

PwQt commented Feb 10, 2024

It seems like everything should be ready - i'll test it this weekend to check whether the release is possible, thanks to PR #52 and @voodoofrog

PwQt added a commit that referenced this issue Feb 10, 2024
@PwQt PwQt linked a pull request Feb 10, 2024 that will close this issue
@PwQt PwQt closed this as completed in #53 Feb 12, 2024
@github-project-automation github-project-automation bot moved this from Testing to Done in Magic Items Feb 12, 2024
@PwQt
Copy link
Owner Author

PwQt commented Feb 12, 2024

Released with 1.6.0

Repository owner locked as resolved and limited conversation to collaborators Feb 12, 2024
@PwQt PwQt removed this from Magic Items Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant