Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Spells in magic Items breaking magic items page #44

Closed
spidermoiz opened this issue Jan 20, 2024 · 1 comment · Fixed by #45
Closed

Multiple Spells in magic Items breaking magic items page #44

spidermoiz opened this issue Jan 20, 2024 · 1 comment · Fixed by #45
Assignees
Labels
bug Something isn't working

Comments

@spidermoiz
Copy link

Module Version: v1.4.6

Describe the Bug
Item is a staff, that has multiple spells and charges used to cast them, currently the item is working, it allows for spells to be cast, however the Magic tab is compeltely blank, and the charges do not get restored daily at dawn automatically anymore. I created a new item and then the magic item page was there, i tried adding spells, but it will break when i add more than 2 spells and then bcome blank again. I see this error in console

Uncaught (in promise) ReferenceError: MagicItem is not defined
at sortByLevel (magic-item-helpers.js:64:34)
at Array.sort ()
at _a.sort (MagicItem.js:54:33)
at _MagicItemTab.render (magicItemtab.js:88:20)
at _MagicItemTab.init (magicItemtab.js:69:10)
at MagicItemTab.bind (magicItemtab.js:17:11)
at Object.fn (module.js:72:16)
at #call (foundry.js:730:20)
at Hooks.callAll (foundry.js:687:17)
at _Tidy5eItemSheet._render (foundry.js:5855:13)
at async _Tidy5eItemSheet._render (foundry.js:6532:5)

Screenshots
image

Browser:

  • Chrome

**Foundry Version: 11.315

**Game System: DND 2.4.1

@spidermoiz spidermoiz added the bug Something isn't working label Jan 20, 2024
@PwQt PwQt added this to Magic Items Jan 20, 2024
@PwQt PwQt moved this to Task in Magic Items Jan 20, 2024
@PwQt PwQt self-assigned this Jan 20, 2024
@PwQt PwQt moved this from Task to In Progress in Magic Items Jan 20, 2024
PwQt added a commit that referenced this issue Jan 20, 2024
@PwQt PwQt linked a pull request Jan 20, 2024 that will close this issue
@PwQt PwQt closed this as completed in #45 Jan 20, 2024
PwQt added a commit that referenced this issue Jan 20, 2024
…eaking-magic-items-page

#44 fix to sortByLevel helper
@github-project-automation github-project-automation bot moved this from In Progress to Done in Magic Items Jan 20, 2024
@PwQt
Copy link
Owner

PwQt commented Jan 20, 2024

Should be fixed in 1.4.7

@PwQt PwQt removed this from Magic Items Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants