Puzzle State Map #76
Merged
Puzzle State Map #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides the majority of the puzzle state map support from the old site. It's missing the ability to group the results, and can't link to the submissions page because it doesn't exist yet, but that's about it.
…s possible that these two can be converted into more efficient queries, but it's beyond my current ability.
|
I'm pretty happy with where this is right now. Not planning any further changes unless reviewers request any. |
asyasky
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
I mostly have non-functional changes (largely around the way I think the project should be structured for easiest maintenance), so if you want you can check in as is and I can go through and make the changes in a separate PR later today. Thanks for getting this logic in!
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the majority of the puzzle state map support from the old site.
It's missing the ability to group the results, and can't link to the
submissions page because it doesn't exist yet, but that's about it.