Database integrity fixes #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabascq
approved these changes
Feb 14, 2019
| @@ -31,6 +31,7 @@ public IActionResult OnGet() | |||
|
|
|||
| public async Task<IActionResult> OnPostAsync() | |||
| { | |||
| ModelState.Remove("Puzzle.Event"); | |||
There was a problem hiding this comment.
I see it in many places but its meaning isn't clear to me.
There was a problem hiding this comment.
It tells the page not to validate the Event property -- as submitted, it's invalid because it's null (and thus a violation of [Required]. We set it further down before sending it to the database. There are some similar cases on Edit pages where we just don't roundtrip a required property (usually the DB just don't get changed for those).
asyasky
approved these changes
Feb 20, 2019
… paths (Event->ContentFile and Event->Puzzle->ContentFile)
morganbr
force-pushed
the
DBIntegrity
branch
from
105e151 to
41799b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various database integrity issues that would either allow corruption or prevent deleting entities. Changes include:
[Required]to foreign key properties where we want cascading deletes (or where it would be bad if the value was ever null)[Required]properties. This typically happens on Create or Edit pages where we set those values after the user submits it or where we don't want to round-trip it through editing.ModelState.Removelets us remove validation for only the fields we know won't matter.Fixes #177, fixes #106, fixes #59, fixes #104