Team navigation & partial auth #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to their team's page!
…the 'Team' menu item at the top
Updates to remove create new for authors and show it on the 'no team' page for players if the event is open for registration
morganbr
approved these changes
Jan 13, 2019
| @@ -8,7 +8,7 @@ | |||
| <h2>All Teams</h2> | |||
|
|
|||
| <p> | |||
| @if (Model.Event.IsTeamRegistrationActive) // Or current user is admin | |||
| @if (Model.Event.IsTeamRegistrationActive && Model.EventRole == ModelBases.EventRole.admin) | |||
There was a problem hiding this comment.
Should this be an 'or' instead of an 'and'?
There was a problem hiding this comment.
There was a change since the comment - this page is only going to be for authors & admins, so if you're not an admin you can't create a team (since authors can't create teams)
| using Microsoft.AspNetCore.Identity; | ||
| using Microsoft.EntityFrameworkCore; | ||
| using ServerCore.DataModel; | ||
| using ServerCore.ModelBases; | ||
|
|
||
| namespace ServerCore.Pages.Teams | ||
| { | ||
| [Authorize(Policy = "IsEventAdminOrEventAuthor")] |
There was a problem hiding this comment.
Since this is becoming an admin view, would it make sense to rename it and make the index be the player page?
There was a problem hiding this comment.
I think that causes a lot of issues with the navigation we have in place (getting to / from teams list) - for now if it's ok I'll leave it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.