Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimes displayed to users should be localized #102

Closed
lambertwang-zz opened this issue Oct 24, 2018 · 1 comment
Closed

DateTimes displayed to users should be localized #102

lambertwang-zz opened this issue Oct 24, 2018 · 1 comment
Assignees
@tabascq
Labels
enhancement New feature or request usability Improvements that make the site easier to use
Milestone
PuzzleHunt Event ...

Comments

@lambertwang-zz
Copy link
Contributor

lambertwang-zz commented Oct 24, 2018 •
edited
Loading

Times are stored in the DB as UTC+0 but should maybe be shown to users in their local time zone. This crops up in a few places
@lambertwang-zz lambertwang-zz added the enhancement New feature or request label Oct 25, 2018
@sprx97 sprx97 self-assigned this Oct 25, 2018
@sprx97
Copy link
Contributor

sprx97 commented Oct 25, 2018

This is bothering me/making validation of certain things difficult, so I'm going to knock this out this weekend.

@jenetlan jenetlan added this to the P1 milestone Jan 17, 2019
@jenetlan jenetlan added the usability Improvements that make the site easier to use label Jan 17, 2019
@tabascq tabascq modified the milestones: P1, PuzzleHunt Event (May) Mar 28, 2019
@tabascq tabascq assigned tabascq and unassigned sprx97 Apr 20, 2019
tabascq pushed a commit to tabascq/mainpuzzleserver that referenced this issue Apr 20, 2019
@kenny-young
Local Time Zone (fixes PuzzleServer#102)
9719479 
All times displayed in the UX for players, authors, and admins now appear in the browser's local time zone, with the exception of the event creation/properties because I don't know how to do the time zone transitions for editable fields.

Internet wisdom is that the only way to do this well is to do it in Javascript because anything done on the server will use the server timezone instead of the user timezone. I searched around for a while to locate the easiest-looking version of this, and it seems to be working properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabascq tabascq

Labels
enhancement New feature or request usability Improvements that make the site easier to use
Projects
None yet
Milestone
PuzzleHunt Event (May)
Development

No branches or pull requests
4 participants
@sprx97 @lambertwang-zz @jenetlan @tabascq