Sanity check for null air turfs trying to update visuals #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On shiptest, we've had a bunch of randomly-occurring auxmos runtimes that I was unable to track down, until now. This should prevent turfs who, while their callback was queued, managed to either stop existing or at the very least lose their air variable. I'm not fully sure that this is the best solution, but it's one that I came up with that seems to work as far as I can tell.
Also clarifies some of the raised errors, as those functions will error on the object itself being null, rather than the variable on the object being null.