Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot unit tests #68

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Add snapshot unit tests #68

wants to merge 13 commits into from

Conversation

alisonhall
Copy link
Collaborator

@alisonhall alisonhall commented Mar 14, 2024 •
edited
Loading

This PR:

  • Creates a method in the test helpers to test page snapshots
  • Creates the missing unit test files
  • Includes HTML snapshot tests for all pages on the site
  • Fixes the pauseFor method to have a variable timeout
  • Renames the existing hamburger unit test file to match the php file name
  • Includes 'todo' unit test statements for files which don't have tests for the functionality

Note, the following unit test snapshots have been skipped due to not returning consistent enough results:

  • animated-gif-with-pause-button.test.js
  • carousel.test.js
  • pause-anim-control.test.js
  • video-player.test.js

Related to #51

Alison Hall and others added 13 commits March 14, 2024 17:34
Rename the hamburger unit test file to match the php file name
8ee6681
Fix the pauseFor method to have a variable timeout
ffc7900
Create a method in the test helpers to test page snapshots
ebd7fb8
Add page snapshot tests to the existing page unit test files
c0c919b
Create missing unit test files and include snapshot tests
259345d
Add unit test snapshot files
572cfaf
Add a script within the package.json to update the snapshots
e276ac0
Add a note about updating the snapshots in the Readme file
ef8477e
Merge branch 'main' into add-snapshot-unit-tests
8e25fb1 
 Conflicts:
	js/test/exposing-style-info-to-screen-readers.test.js
Update the code quality page snapshot with latest content
4eb2a6e
Merge branch 'main' into add-snapshot-unit-tests
59678c4
Merge branch 'main' into add-snapshot-unit-tests
71665ce
@zoltan-dulac
Merge branch 'main' into add-snapshot-unit-tests
644a714
@alisonhall alisonhall linked an issue May 28, 2024 that may be closed by this pull request
Add snapshot unit tests #51
Open
@alisonhall alisonhall marked this pull request as draft June 6, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add snapshot unit tests
2 participants
@alisonhall @zoltan-dulac